Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KubeVirt cleanup small wrong code (preference error check) #1480

Merged
merged 1 commit into from
Nov 16, 2022
Merged

KubeVirt cleanup small wrong code (preference error check) #1480

merged 1 commit into from
Nov 16, 2022

Conversation

hdurand0710
Copy link
Contributor

Signed-off-by: Helene Durand [email protected]

What this PR does / why we need it:
This PR cleans up a small wrong code. Behaviour does not change but this lines should go.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind cleanup

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@hdurand0710 hdurand0710 added the sig/virtualization Denotes a PR or issue as being assigned to SIG Virtualization. label Nov 14, 2022
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2022
@hdurand0710
Copy link
Contributor Author

/retest

2 similar comments
@hdurand0710
Copy link
Contributor Author

/retest

@hdurand0710
Copy link
Contributor Author

/retest

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7b719575858a79a378fe7560298f606673e06eb3

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, hdurand0710

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2022
@ahmedwaleedmalik
Copy link
Member

/retest

1 similar comment
@hdurand0710
Copy link
Contributor Author

/retest

@hdurand0710
Copy link
Contributor Author

hdurand0710 commented Nov 15, 2022 •
edited
Loading

For AWs, tests are failing with
E1115 08:59:37.676286 1 machine_controller.go:382] Failed to reconcile machine "centos-1-23-13-aws-1592439865218174976-6df6478964-rzh58": An error of type = InvalidConfiguration, with message = Failed to get AMI-ID for operating system centos in region eu-central-1: could not find Image for 'centos' with arch 'x86_64' occurred

@hdurand0710
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot merged commit 5795007 into kubermatic:main Nov 16, 2022
@hdurand0710 hdurand0710 deleted the fix-pref-wrong-merge branch November 22, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/osm Denotes a PR or issue as being assigned to SIG OSM. sig/virtualization Denotes a PR or issue as being assigned to SIG Virtualization. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hdurand0710 @kubermatic-bot @ahmedwaleedmalik