Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restart containerd for flatcar so the drop in conf will be considered #1476

Merged
merged 2 commits into from
Nov 7, 2022
Merged

restart containerd for flatcar so the drop in conf will be considered #1476

merged 2 commits into from
Nov 7, 2022

Conversation

lucakuendig
Copy link
Contributor

@lucakuendig lucakuendig commented Nov 4, 2022 •
edited by ahmedwaleedmalik
Loading

Signed-off-by: Luca Kuendig [email protected]

What this PR does / why we need it:
I noticed, that during the first boot of a Flatcar node custom configurations, like containerd custom registry endpoint and auth, will not be used. I think it is because compared to other operatingsystems Flatcar allready has containerd installed and starts it directly after boot, so systemctl enable --now does nothing. By restarting the containerd service instead of systemctl enable (should be enabled by default) The config will be picked up on the first boot.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 4, 2022
@kubermatic-bot
Copy link
Contributor

Hi @lucakuendig. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 4, 2022
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Nov 4, 2022
@ahmedwaleedmalik
Copy link
Member

/ok-to-test

@kubermatic-bot kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 4, 2022
@ahmedwaleedmalik
Copy link
Member

@lucakuendig the fixture data needs to be updated. Please run the script hack/update-fixtures.sh.

@lucakuendig
update fixture data
b90dc29 
Signed-off-by: Luca Kuendig <[email protected]>
@kubermatic-bot kubermatic-bot added sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2022
@ahmedwaleedmalik ahmedwaleedmalik added the kind/bug Categorizes issue or PR as related to a bug. label Nov 7, 2022
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Nov 7, 2022
Merged
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you for taking care of this. 🚀

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 193b0613e7f268d779a4b2e578aecdcbca6b747a

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, lucakuendig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@kubermatic-bot kubermatic-bot merged commit b70f5d2 into kubermatic:main Nov 7, 2022
@lucakuendig lucakuendig mentioned this pull request Jan 30, 2023
Closed
mate4st pushed a commit to mate4st/machine-controller that referenced this pull request Mar 13, 2023
@lucakuendig @mate4st
restart containerd for flatcar so the drop in conf will be considered (…
d93a478 
…kubermatic#1476)

* restart containerd for flatcar so the drop in conf will be considered

Signed-off-by: Luca Kuendig <[email protected]>

* update fixture data

Signed-off-by: Luca Kuendig <[email protected]>

Signed-off-by: Luca Kuendig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucakuendig @kubermatic-bot @ahmedwaleedmalik