Fix static network rendering for flatcar #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
|
/retest |
Signed-off-by: Waleed Malik <[email protected]>
ahmedwaleedmalik
force-pushed
the
fix-flatcar-network-rendering
branch
from
e54baed to
7211750
Compare
PratikDeoghare
approved these changes
Nov 2, 2022
|
LGTM label has been added. Git tree hash: 843edf602cb988747e6ff2819812a5b73da5a264
|
|
/retest |
1 similar comment
|
/retest |
mate4st
pushed a commit
to mate4st/machine-controller
that referenced
this pull request
Mar 13, 2023
Signed-off-by: Waleed Malik <[email protected]> Signed-off-by: Waleed Malik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Waleed Malik [email protected]
What this PR does / why we need it:
Fixes a bug where static networking configuration was being wrongfully set for flatcar.
Which issue(s) this PR fixes:
Fixes #1468
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: