Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cluster labels to kubevirt vm #1472

Merged
merged 6 commits into from
Nov 23, 2022
Merged

Add cluster labels to kubevirt vm #1472

merged 6 commits into from
Nov 23, 2022

Conversation

dermorz
Copy link
Contributor

@dermorz dermorz commented Nov 2, 2022

What this PR does / why we need it:
For kubermatic/kubermatic#10923 we need to add cluster labels to KubeVirt VMs on creation.

Does this PR introduce a user-facing change? Then add your Release Note here:

Add cluster labels to KubeVirt VM

Documentation:

NONE

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 2, 2022
@dermorz dermorz force-pushed the add-cluster-labels-to-kubevirt-vm branch 2 times, most recently from c2c7b57 to a55a577 Compare November 2, 2022 13:28
@dermorz dermorz requested a review from hdurand0710 November 7, 2022 08:18
@dermorz dermorz force-pushed the add-cluster-labels-to-kubevirt-vm branch from 42754c9 to e074335 Compare November 7, 2022 13:48
@hdurand0710
Copy link
Contributor

/hold I would need to check something in kubevirt ccm.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022
@dermorz dermorz force-pushed the add-cluster-labels-to-kubevirt-vm branch from e4bf209 to 46dfb21 Compare November 8, 2022 11:43
@hdurand0710
Copy link
Contributor

Can you please also update examples/kubevirt-machinedeployment.yaml with the new parameter ?

@hdurand0710
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: df8c9b82fcf10f94e073b210444bf7c411a0ba06

@dermorz
Copy link
Contributor Author

dermorz commented Nov 14, 2022

Can you please also update examples/kubevirt-machinedeployment.yaml with the new parameter ?

Yes, and also docs/kubevirt.md.

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2022
@dermorz
Copy link
Contributor Author

dermorz commented Nov 14, 2022

/retest

2 similar comments
@dermorz
Copy link
Contributor Author

dermorz commented Nov 14, 2022

/retest

@dermorz
Copy link
Contributor Author

dermorz commented Nov 15, 2022

/retest

@dermorz dermorz force-pushed the add-cluster-labels-to-kubevirt-vm branch from 57d04a7 to 1a463e4 Compare November 16, 2022 10:51
@dermorz
Copy link
Contributor Author

dermorz commented Nov 16, 2022

/retest

@dermorz
Copy link
Contributor Author

dermorz commented Nov 21, 2022

/retest

@hdurand0710
Copy link
Contributor

/unhold
KKP is merged

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2022
@dermorz
Copy link
Contributor Author

dermorz commented Nov 21, 2022

/retest

@hdurand0710
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3d2c8f5aa0307e7fc4ace8d17a79eab92c2712b3

@dermorz
Copy link
Contributor Author

dermorz commented Nov 22, 2022

/retest

@dermorz
Copy link
Contributor Author

dermorz commented Nov 22, 2022

/assign @ahmedwaleedmalik

@dermorz
Add cluster labels to KubeVirt VM
d28ac6f 
Linter: Drop unnecessary else block

Signed-off-by: Moritz Bracht <[email protected]>

Use MC namespace as cluster-name label

Signed-off-by: Moritz Bracht <[email protected]>
@dermorz
Upgrade kubevirt.io/api to v0.58.0
a92fb34 
Signed-off-by: Moritz Bracht <[email protected]>
@dermorz
Clean up trailing whitespace
34be677 
Signed-off-by: Moritz Bracht <[email protected]>
@dermorz
Adjust test data to new cluster labels
ba35ef4 
Signed-off-by: Moritz Bracht <[email protected]>

Fix typo

Signed-off-by: Moritz Bracht <[email protected]>

revert rename of test-namespace

Signed-off-by: Moritz Bracht <[email protected]>
@dermorz
Add ClusterName to KubeVirt providerconfig
fe60576 
Signed-off-by: Moritz Bracht <[email protected]>
@dermorz
Add documentation of new clusterName field for kubevirt
4b5c157 
Signed-off-by: Moritz Bracht <[email protected]>
@dermorz dermorz force-pushed the add-cluster-labels-to-kubevirt-vm branch from 1a463e4 to 4b5c157 Compare November 22, 2022 14:19
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2022
@hdurand0710
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bda20dc3a16828a3698542d9e2dcf754dfdfd6b0

@ahmedwaleedmalik
Copy link
Member

/retest

@ahmedwaleedmalik
Copy link
Member

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, dermorz, hdurand0710

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2022
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot kubermatic-bot merged commit 798bc63 into kubermatic:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdurand0710 hdurand0710 Awaiting requested review from hdurand0710

@ahmedwaleedmalik ahmedwaleedmalik Awaiting requested review from ahmedwaleedmalik

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

@hdurand0710 hdurand0710

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dermorz @hdurand0710 @kubermatic-bot @ahmedwaleedmalik @kubermatic-triage-bot