Dualstack support with AWS CCM #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note-none
kubermatic-bot
added
size/XS
sachintiptur
changed the title
kubermatic-bot
removed
the
do-not-merge/work-in-progress
sachintiptur
force-pushed
the
aws_ds
branch
3 times, most recently
from
0f30758 to
f9a7f4d
Compare
|
/retest |
sachintiptur
force-pushed
the
aws_ds
branch
2 times, most recently
from
9d8ca61 to
359414b
Compare
Signed-off-by: Sachin Tiptur <[email protected]>
|
/retest |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 22fc5bbfacd271fc06fc0f6fc0bd8e2bf86ba984
|
|
/assign @ahmedwaleedmalik |
ahmedwaleedmalik
approved these changes
Oct 25, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, sachintiptur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
OSM does not need these changes as Kubermatic imports only the structure from MC and does configure the cloud-config for control plane node. |
lucakuendig
pushed a commit
to lucakuendig/machine-controller
that referenced
this pull request
Oct 28, 2022
Signed-off-by: Sachin Tiptur <[email protected]> Signed-off-by: Sachin Tiptur <[email protected]>
mate4st
pushed a commit
to mate4st/machine-controller
that referenced
this pull request
Mar 13, 2023
Signed-off-by: Sachin Tiptur <[email protected]> Signed-off-by: Sachin Tiptur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sachin Tiptur [email protected]
What this PR does / why we need it:
This PR adds NodeIPFamilies to GlobalOpts struct. This is required in Kubermatic repo for adding dual stack support with AWS CCM which is enabled with control plane version 1.24 onwards.
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind feature
Special notes for your reviewer:
This is only a struct change, the actual logic will be added in Kubermatic repo.
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: