Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump KubeVirt CDI to 1.55.0 #1456

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Bump KubeVirt CDI to 1.55.0 #1456

merged 1 commit into from
Oct 6, 2022

Conversation

hdurand0710
Copy link
Contributor

What this PR does / why we need it:
Bump KubeVirt CDI to 1.55.0 and fix examples/kubevirt-machinedeployment.yaml.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Bump KubeVirt CDI to 1.55.0

Documentation:

NONE

@hdurand0710 hdurand0710 added the sig/virtualization Denotes a PR or issue as being assigned to SIG Virtualization. label Oct 6, 2022
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2022
@hdurand0710 hdurand0710 mentioned this pull request Oct 6, 2022
Merged
@mfranczy
Copy link
Contributor

mfranczy commented Oct 6, 2022

/test pull-machine-controller-e2e-kubevirt

mfranczy
mfranczy approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@mfranczy mfranczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c0979f4e1da8111a82401186f293b67dfd14bd1d

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, hdurand0710, mfranczy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,hdurand0710,mfranczy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hdurand0710
Copy link
Contributor Author

vsphere is ok :-) the other 2 were so surprised that they failed :-)

@hdurand0710
Copy link
Contributor Author

/retest

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot kubermatic-bot merged commit 7784255 into kubermatic:master Oct 6, 2022
@hdurand0710 hdurand0710 deleted the bump-cdi-1.55.0 branch October 7, 2022 06:15
mate4st pushed a commit to mate4st/machine-controller that referenced this pull request Mar 13, 2023
@hdurand0710 @mate4st
Bump KubeVirt CDI to 1.55.0 (kubermatic#1456)
1942e51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranczy mfranczy mfranczy approved these changes

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

@mfranczy mfranczy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/virtualization Denotes a PR or issue as being assigned to SIG Virtualization. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hdurand0710 @mfranczy @kubermatic-bot @kubermatic-triage-bot @ahmedwaleedmalik