Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to enable nested virtualization and CPU platform for GCP #1451

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Add an option to enable nested virtualization and CPU platform for GCP #1451

merged 2 commits into from
Sep 30, 2022

Conversation

mfranczy
Copy link
Contributor

What this PR does / why we need it:
Allows to use nested virtualization on GCP

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Enable nested virtualization for GCP cloud provider

Documentation:

NONE

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2022
@mfranczy mfranczy force-pushed the nested-and-cpu-platform branch from ef24c12 to c70efaf Compare September 29, 2022 14:16
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a4a511d4be36c0611f3d4e82cb1091f89701d0eb

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, mfranczy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@kubermatic-bot kubermatic-bot merged commit 0b32bbe into kubermatic:master Sep 30, 2022
mate4st pushed a commit to mate4st/machine-controller that referenced this pull request Mar 13, 2023
@mfranczy @mate4st
Add an option to enable nested virtualization and CPU platform for GCP (
48ae5a3 
kubermatic#1451)

* Add an option to enable nested virtualization and CPU platform for GCP

Signed-off-by: Marcin Franczyk <[email protected]>

* adjust minCPUPlatform name to linter rules

Signed-off-by: Marcin Franczyk <[email protected]>

Signed-off-by: Marcin Franczyk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfranczy @kubermatic-bot @ahmedwaleedmalik