Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.42] Fix unmarshalling for configvarstring in cloudProviderSpec #1415

Merged
merged 1 commit into from
Aug 23, 2022
Merged

[release/v1.42] Fix unmarshalling for configvarstring in cloudProviderSpec #1415

merged 1 commit into from
Aug 23, 2022

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #1367

/assign ahmedwaleedmalik

Fix unmarshalling for `configvarstring` in cloudProviderSpec.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Aug 23, 2022
@kubermatic-bot kubermatic-bot mentioned this pull request Aug 23, 2022
Merged
@kubermatic-bot kubermatic-bot added sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 23, 2022
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2022
@kubermatic-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: e663c598fddd5d62db1d6c300b3ba19b865250d9

@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, kubermatic-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
@kubermatic-bot
Copy link
Contributor Author

@kubermatic-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-e2e-azure b5be5ef link true /test pull-machine-controller-e2e-azure
pull-machine-controller-e2e-azure-custom-image-reference b5be5ef link true /test pull-machine-controller-e2e-azure-custom-image-reference
pull-machine-controller-e2e-aws-spot-instance b5be5ef link true /test pull-machine-controller-e2e-aws-spot-instance
pull-machine-controller-e2e-hetzner b5be5ef link true /test pull-machine-controller-e2e-hetzner
pull-machine-controller-e2e-ubuntu-upgrade b5be5ef link true /test pull-machine-controller-e2e-ubuntu-upgrade

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ahmedwaleedmalik ahmedwaleedmalik merged commit 06c8dd0 into kubermatic:release/v1.42 Aug 23, 2022
@kubermatic-bot kubermatic-bot deleted the cherry-pick-1367-to-release/v1.42 branch October 4, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubermatic-bot @ahmedwaleedmalik