improve kubeconfig/gcp handling of credentials in e2e tests

[xrstf]

What this PR does / why we need it:
This PR ensures that we always inject a base64-encoded kubeconfig in the kubevirt config, even if (in the future) an unencoded kubeconfig was provided in the e2e tests / via env vars. The same careful handling was added to the GCP SA, which also needs to be base64-encoded, which was never mentioned anywhere.

Nothing changes for the users. This only affects our testing.

/kind cleanup
Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

[xmudrii]

/lgtm
/approve

[xrstf]

/hold

[ahmedwaleedmalik]

This PR ensures that we always inject a base64-encoded kubeconfig in the kubevirt config, even if (in the future) an unencoded kubeconfig was provided (which is what 99% of users will have at hand)

This statement is quite misleading. You are not mentioning that your change is only applicable to our "E2E tests". So for a normal user, this will have no effect.

[xrstf]

So for a normal user, this will have no effect.

Yes, and that's a feature. I did not intend to break people's stuff. I only intend to fix our e2e stuff.

[xmudrii]

/lgtm
/approve

[xmudrii]

/lgtm cancel

[xrstf]

/unhold

[kubermatic-bot]

LGTM label has been added.

Git tree hash: 47025ed3837e133f31bc7eda7bbbfb3b1b884503

[ahmedwaleedmalik]

/approve

[kubermatic-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xmudrii, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahmedwaleedmalik,xmudrii,xrstf]
• pkg/cloudprovider/provider/OWNERS [ahmedwaleedmalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[xrstf]

/override pull-machine-controller-e2e-openstack
/override pull-machine-controller-e2e-openstack-project-auth
/override pull-machine-controller-e2e-ubuntu-upgrade
/override pull-machine-controller-e2e-vsphere

[kubermatic-bot]

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-openstack, pull-machine-controller-e2e-openstack-project-auth, pull-machine-controller-e2e-ubuntu-upgrade, pull-machine-controller-e2e-vsphere

In response to this:

/override pull-machine-controller-e2e-openstack
/override pull-machine-controller-e2e-openstack-project-auth
/override pull-machine-controller-e2e-ubuntu-upgrade
/override pull-machine-controller-e2e-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xrstf]

/cherrypick release/v1.43

[xrstf]

/cherrypick release/v1.45

[xrstf]

/cherrypick release/v1.42

[kubermatic-bot]

@xrstf: #1404 failed to apply on top of branch "release/v1.43":

Applying: make it clear where and how to base64 encode the kubevirt kubeconfig
Using index info to reconstruct a base tree...
M	docs/cloud-provider.md
M	examples/kubevirt-machinedeployment.yaml
M	test/e2e/provisioning/all_e2e_test.go
M	test/e2e/provisioning/testdata/machinedeployment-kubevirt.yaml
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/provisioning/testdata/machinedeployment-kubevirt.yaml
CONFLICT (content): Merge conflict in test/e2e/provisioning/testdata/machinedeployment-kubevirt.yaml
Auto-merging test/e2e/provisioning/all_e2e_test.go
Auto-merging examples/kubevirt-machinedeployment.yaml
CONFLICT (content): Merge conflict in examples/kubevirt-machinedeployment.yaml
Auto-merging docs/cloud-provider.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 make it clear where and how to base64 encode the kubevirt kubeconfig
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release/v1.43

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kubermatic-bot]

@xrstf: #1404 failed to apply on top of branch "release/v1.45":

Applying: make it clear where and how to base64 encode the kubevirt kubeconfig
Using index info to reconstruct a base tree...
M	docs/cloud-provider.md
M	examples/kubevirt-machinedeployment.yaml
M	test/e2e/provisioning/all_e2e_test.go
M	test/e2e/provisioning/testdata/machinedeployment-kubevirt.yaml
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/provisioning/testdata/machinedeployment-kubevirt.yaml
CONFLICT (content): Merge conflict in test/e2e/provisioning/testdata/machinedeployment-kubevirt.yaml
Auto-merging test/e2e/provisioning/all_e2e_test.go
Auto-merging examples/kubevirt-machinedeployment.yaml
CONFLICT (content): Merge conflict in examples/kubevirt-machinedeployment.yaml
Auto-merging docs/cloud-provider.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 make it clear where and how to base64 encode the kubevirt kubeconfig
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release/v1.45

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kubermatic-bot]

@xrstf: #1404 failed to apply on top of branch "release/v1.42":

Applying: make it clear where and how to base64 encode the kubevirt kubeconfig
Using index info to reconstruct a base tree...
M	docs/cloud-provider.md
M	examples/kubevirt-machinedeployment.yaml
M	test/e2e/provisioning/all_e2e_test.go
M	test/e2e/provisioning/testdata/machinedeployment-kubevirt.yaml
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/provisioning/testdata/machinedeployment-kubevirt.yaml
CONFLICT (content): Merge conflict in test/e2e/provisioning/testdata/machinedeployment-kubevirt.yaml
Auto-merging test/e2e/provisioning/all_e2e_test.go
Auto-merging examples/kubevirt-machinedeployment.yaml
CONFLICT (content): Merge conflict in examples/kubevirt-machinedeployment.yaml
Auto-merging docs/cloud-provider.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 make it clear where and how to base64 encode the kubevirt kubeconfig
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release/v1.42

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.