Update grafanasdk to latest changes in upstream #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of getting an error like:
unmarshal board: json: cannot unmarshal object into Go struct field Target.targets.group of type []struct { Type string "json:\"type,omitempty\""; Params []string "json:\"params,omitempty\"" } for 000000312 AWS Cloudwatch Browser
It will now mention the panel:
unmarshal board: json: cannot unmarshal object into Go struct field Target.targets.group of type []struct { Type string "json:\"type,omitempty\""; Params []string "json:\"params,omitempty\"" } (panel "Metric" of type "graph") for 000000312 AWS Cloudwatch Browser
Signed-off-by: Oleg Zaytsev <[email protected]>
In recent versions of Grafana the datasource can be either a string or a map with entries for type and uid. Support both of these cases by using an interface which will allow backwards compatiblity.
Threshold value is defined as a number in Grafana (and also min and max): http://github.com/grafana/grafana/blob/dd2a952c29db6d190dacdd6c06dd748f7912db9e/packages/grafana-data/src/types/thresholds.ts#L2-L2 I was tempted to use a json.Number for this, but apparently the convention is to just use floats, so I went for that. Signed-off-by: Oleg Zaytsev <[email protected]>
* user password * add password integration test * password not return bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.