Skip to content

Commit

Permalink
🐛: Target.GroupBy should be singular in the type declaration (grafana…
Browse files Browse the repository at this point in the history
…-tools#180)

* GroupBy should be singular in the JSON

* fix json declaration for groupBy

Co-authored-by: Tank <[email protected]>
  • Loading branch information
2 people authored and wurbanski committed Mar 30, 2022
1 parent b02c34d commit 39c30e3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion panel.go
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ type Target struct {
CrossSeriesReducer string `json:"crossSeriesReducer,omitempty"`
PerSeriesAligner string `json:"perSeriesAligner,omitempty"`
ValueType string `json:"valueType,omitempty"`
GroupBys []string `json:"groupBys,omitempty"`
GroupBy []string `json:"groupBy,omitempty"`
Tags []struct {
Key string `json:"key,omitempty"`
Operator string `json:"operator,omitempty"`
Expand Down
2 changes: 1 addition & 1 deletion panel_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ func TestPanel_Stackdriver_ParsedTargets(t *testing.T) {
"=",
"some_subscription_id"
],
"groupBys": [],
"groupBy": [],
"metricKind": "DELTA",
"metricType": "pubsub.googleapis.com/subscription/ack_message_count",
"perSeriesAligner": "ALIGN_DELTA",
Expand Down

0 comments on commit 39c30e3

Please sign in to comment.