Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KubeVirt: Support for VPC and Subnets #6941

Merged
merged 4 commits into from
Oct 22, 2024
Merged

KubeVirt: Support for VPC and Subnets #6941

merged 4 commits into from
Oct 22, 2024

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Oct 17, 2024 •
edited
Loading

What this PR does / why we need it:
Builds on top of kubermatic/machine-controller#1862 and adds support on UI for using VPC at cluster level and subnets and machine level.

Short demonstration of the feature

Screen.Recording.2024-10-18.at.15.27.53.mov

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Support for Kube-OVN subnet and VPCs for KubeVirt

Documentation:

NONE

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Oct 17, 2024
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/api Denotes a PR or issue as being assigned to SIG API. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 17, 2024
@ahmedwaleedmalik ahmedwaleedmalik changed the title [WIP] KubeVirt: Support for VPC and Subnets KubeVirt: Support for VPC and Subnets Oct 18, 2024
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 18, 2024
@ahmedwaleedmalik
Copy link
Member Author

/retest

@moadqassem
Copy link
Member

@ahmedwaleedmalik Any idea what we need to do to get this PR merged ?

@ahmedwaleedmalik
Copy link
Member Author

@ahmedwaleedmalik Any idea what we need to do to get this PR merged ?

We couldn't test it previously because of the issues with dev. @Waseem826 is currently reviewing it and i'm testing the final parts.

@ahmedwaleedmalik
Refactored code
68eb0e3 
Signed-off-by: Waleed Malik <[email protected]>
Waseem826
Waseem826 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cb7d8f7d3efd1a02e39841e90ee68b3d53c78ae6

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2024
@kubermatic-bot kubermatic-bot merged commit 037261f into kubermatic:main Oct 22, 2024
13 of 14 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.27 milestone Oct 22, 2024
@ahmedwaleedmalik ahmedwaleedmalik deleted the kubevirt-vpc-subnets branch October 22, 2024 09:03
@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v2.26

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #6963

In response to this:

/cherry-pick release/v2.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Nov 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waseem826 Waseem826 Waseem826 approved these changes

Assignees

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.27
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmedwaleedmalik @moadqassem @kubermatic-bot @Waseem826