Sample implementation of using Kubernetes leases instead of daemonset lock #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lock Signed-off-by: jmcshane <[email protected]>
|
This PR was automatically considered stale due to lack of activity. Please refresh it and/or join our slack channels to highlight it, before it automatically closes (in 7 days). |
|
I would like to dig deeper into this. I need to understand more about leases behaviour, api impact on large clusters. Okay to discuss this ? I added you on linkedin for better coordination. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #25
This is a demo implementation that I have working in my local environment. We can't directly use the
leaderelectionpackage from client-go without some modification (the daemonset will persist post restart of the node, so the original context of leader election will be lost).Would love to chat about this implementation and get it ready for inclusion in this library. Thanks for your work on this great tool!