Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ARM-Support #481

Closed
wants to merge 1 commit into from
Closed

[WIP] ARM-Support #481

wants to merge 1 commit into from

Conversation

ckotzbauer
Copy link
Member

@ckotzbauer ckotzbauer commented Dec 11, 2021

This is a WIP-PR of a build with ARM support.
I'm not really sure about the changes in the Makefile. With the changes for windows-support in mind from #460 this would create more and more complicated tooling-scripts to maintain.

My personal favourite is to do only the go-compilation and other small tasks in the makefile and move the image build and -publish to Github Actions which are already able to create multiarch-builds out of the box. But this would remove the ability to create images locally (without writing the commands on your own).

I also would suggest to not separate different architectures by image-tag and use the same tags for different arches.

WDYT?

Ref: #23

Signed-off-by: Christian Kotzbauer <[email protected]>
@davideshay
Copy link
Contributor

Glad someone else is concerned about arm64 builds. I've provided an alternative to this PR here:
#496

This is a more traditional multi-arch build support approach on github actions using qemu and docker buildx with multi-platform support. No changes to existing makefile were required, but I did move some of the go-build steps to the Dockerfile. Not entirely sure about the approach listed here, but I'm not sure it would generate a multiple-arch manifest, whereas the approach in 496 will.

@github-actions
Copy link

This PR was automatically considered stale due to lack of activity. Please refresh it and/or join our slack channels to highlight it, before it automatically closes (in 7 days).

@ckotzbauer
Copy link
Member Author

superseded by #496

@ckotzbauer ckotzbauer closed this Mar 15, 2022
@ckotzbauer ckotzbauer deleted the feature/arm-support branch March 15, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants