run script

[kfox1111]

Some updates that can happen need to happen after the node is drained to not effect workload. (some kinds of docker upgrades for example)

So the procedure might be:

1. detect upgrades, flag node
2. controller sees flag, drains node
3. upgrades applied on the node
4. reboot
5. controller uncordons

Can a hook on the node agent be added to run a script before reboot but after drain?

[kfox1111]

actually, maybe the default script should do the reboot.

There could be a case where you want to drain the node, update some software and then uncordon the node without rebooting.

[evrardjp]

I am not sure we should keep this issue open... Kured is about rebooting :)
Though I suspect that for your case, having a configurable restart command could do the trick?

[kfox1111]

vm's tend to reboot quick so making the distinction between reboot and just restarting services that were updated probably doesn't help much.

On bare metal though, bios's can take 5-10 minutes to post in some cases. On a larger cluster this adds up. Being able to override the reboot to skip it if unneeded or wire in a kexec to bypass the bios could really benefit users of this type of cluster.

Yeah, I think the ability to just override the reboot command might be enough.

[evrardjp]

Awesome, thanks!

[evrardjp]

@dholbach we can probably close this for now, as we can track it in #122 .

[dholbach]

Maybe we can collect use-cases and stories in #122 so we can make sure we target them all and have e.g docs and tests where applicable too?

[evrardjp]

Yup that sounds fine for me. I thought just pointing to the appropriate issues/PRs there would be enough, but if you want to summarize, feel free! :p

[github-actions]

This issue was automatically considered stale due to lack of activity. Please update it and/or join our slack channels to promote it, before it automatically closes (in 7 days).