Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement configurable sentinel/reboot commands #122

Closed
evrardjp opened this issue Mar 25, 2020 · 8 comments
Closed

Implement configurable sentinel/reboot commands #122

evrardjp opened this issue Mar 25, 2020 · 8 comments

Comments

@evrardjp
Copy link
Collaborator

evrardjp commented Mar 25, 2020

@evrardjp evrardjp changed the title Implement configurable reboot command Implement configurable sentinel/reboot commands Mar 25, 2020
@evrardjp evrardjp mentioned this issue Mar 25, 2020
@stuartpb
Copy link

If you're gathering use cases, I'll note that Kubic has a wide variety of alternatives to kured, like kexec: https://kubic.opensuse.org/documentation/man-pages/transactional-update.conf.5.html

@smueller18
Copy link
Contributor

I have another use case for my cluster. Whenever kured reboots a node, the default alerts for ceph storage pods are firing for some minutes until the pods are ready again after the reboot.
The amtool binary can be used to silence alertmanager alerts. An example command to silence an alert is

amtool --alertmanager.url="http://localhost:9093" silence add --duration="30m" --author="kubernetes" --comment="reboot host" alertname="MyAlertName" host="$HOST"

It would be nice, if kured offers the ability to run such kinds of commands right before the reboot command is triggered.

I already though about alternatives, but none of them works:

  • PreStop of kured pod hook executes amtool: runs always when the pod is terminated, not only on reboots by kured
  • executes amtool by a systemd service on the host: not native kubernetes and runs also if not triggered by kured

@evrardjp
Copy link
Collaborator Author

If you're gathering use cases, I'll note that Kubic has a wide variety of alternatives to kured, like kexec: https://kubic.opensuse.org/documentation/man-pages/transactional-update.conf.5.html

These seem to be the target of a transactional update action, which means that transactional update action can call kured, and if kured is configured to call kexec, that would work... Sounds a tad complex though :)

@github-actions
Copy link

This issue was automatically considered stale due to lack of activity. Please update it and/or join our slack channels to promote it, before it automatically closes (in 7 days).

@evrardjp
Copy link
Collaborator Author

Curently stale, but we should keep this issue opened, as it's the way to track all the sub issues.

We just have prioritized the testing first.

@github-actions
Copy link

This issue was automatically considered stale due to lack of activity. Please update it and/or join our slack channels to promote it, before it automatically closes (in 7 days).

@anthr76
Copy link

anthr76 commented Apr 14, 2021

kexec would be great! Any thoughts from a maintainer on opening this back up?

@evrardjp
Copy link
Collaborator Author

It's not only about kexec... !

But guess what?! It's implemented in our main branch (See also #297) ! It will be available on the next release, which should happen soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants