Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controller: generate stable annotations for pod routes #4889

Merged
merged 2 commits into from
Jan 2, 2025
Merged

controller: generate stable annotations for pod routes #4889

merged 2 commits into from
Jan 2, 2025

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Dec 31, 2024 •
edited
Loading

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes vpc-egress-gateway e2e test failure.

@zhangzujian zhangzujian changed the title fix vpc egress gateway e2e test controller: generate stable annotations for pod routes Jan 2, 2025
@zhangzujian zhangzujian marked this pull request as ready for review January 2, 2025 04:02
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. vpc labels Jan 2, 2025
@zhangzujian zhangzujian requested a review from oilbeater January 2, 2025 04:04
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12577358223

Details

  • 4 of 17 (23.53%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 22.08%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/util/pod_routes.go 4 5 80.0%
pkg/controller/vpc.go 0 3 0.0%
pkg/apis/kubeovn/v1/vpc.go 0 9 0.0%
Totals Coverage Status
Change from base Build 12576329082: 0.001%
Covered Lines: 10164
Relevant Lines: 46033
💛 - Coveralls

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 2, 2025
@zhangzujian zhangzujian merged commit 4d3dd9c into kubeovn:master Jan 2, 2025
68 checks passed
@zhangzujian zhangzujian deleted the fix-egress-gw branch January 2, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oilbeater oilbeater oilbeater approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. vpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangzujian @coveralls @oilbeater