Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: kube-ovn-controller cannot be ready when ENABLE_METRICS is false #4886

Merged
merged 2 commits into from
Jan 3, 2025
Merged

fix: kube-ovn-controller cannot be ready when ENABLE_METRICS is false #4886

merged 2 commits into from
Jan 3, 2025

Conversation

zhaocongqi
Copy link
Member

Pull Request

What type of this PR

Examples of user facing changes:

  • Bug fixes

Which issue(s) this PR fixes

Fixes #4862

@coveralls
Copy link

coveralls commented Dec 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12593857671

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 22.08%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/ovnmonitor/config.go 0 2 0.0%
pkg/speaker/config.go 0 2 0.0%
Totals Coverage Status
Change from base Build 12577942218: 0.0%
Covered Lines: 10164
Relevant Lines: 46033
💛 - Coveralls

zbb88888
zbb88888 reviewed Dec 30, 2024
View reviewed changes
cmd/ovn_monitor/ovn_monitor.go Outdated Show resolved Hide resolved
cmd/pinger/pinger.go Outdated Show resolved Hide resolved
@zhaocongqi zhaocongqi marked this pull request as ready for review December 31, 2024 08:35
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Dec 31, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 3, 2025
@zbb88888 zbb88888 merged commit 44fcf08 into kubeovn:master Jan 3, 2025
67 checks passed
@zhaocongqi zhaocongqi deleted the fix-metrics branch January 6, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangzujian zhangzujian zhangzujian approved these changes

@zbb88888 zbb88888 zbb88888 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] kube-ovn-controller cannot be ready when ENABLE_METRICS is false
4 participants
@zhaocongqi @coveralls @zbb88888 @zhangzujian