-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pod should use mac and ips provider by multus firstly #4800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Dec 6, 2024
Pull Request Test Coverage Report for Build 12504977336Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
加个 e2e case? |
zhangzujian
reviewed
Dec 9, 2024
zhangzujian
reviewed
Dec 9, 2024
zhangzujian
reviewed
Dec 9, 2024
bobz965
reviewed
Dec 9, 2024
1 |
Signed-off-by: clyi <[email protected]>
changluyi
force-pushed
the
mac_and_ip_should_be_provided_by_multus
branch
from
December 25, 2024 02:06
92158c6
to
d21595e
Compare
Signed-off-by: clyi <[email protected]>
Signed-off-by: clyi <[email protected]>
Signed-off-by: clyi <[email protected]>
oilbeater
approved these changes
Dec 27, 2024
changluyi
added a commit
that referenced
this pull request
Dec 27, 2024
* pod should use mac and ips provider by multus firstly --------- Signed-off-by: clyi <[email protected]>
changluyi
added a commit
that referenced
this pull request
Dec 27, 2024
* pod should use mac and ips provider by multus firstly --------- Signed-off-by: clyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)