Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Optimize node gc method #4714

Closed
wants to merge 1 commit into from
Closed

Conversation

cmdy
Copy link
Contributor

@cmdy cmdy commented Nov 8, 2024

Pull Request

What type of this PR

Examples of user facing changes:

  • Bug fixes

Which issue(s) this PR fixes

Fixes #(issue-number)

  1. When the controller is stopped, the node is deleted, and then the controller is restarted, the logical router policy with a priority of 29000 is not properly cleared.
    image
  2. Although ovn-controller will skip the error in the picture, it will cause some retries,this causes the ovn-controller to start slowly and the flow table information to be delivered slowly in a large-scale cluster(2000+ node,15w+ pod,100+ subnet).
  3. fix kube-ovn-cni crash for newly added nodes , due to old legacy event #4194 This PR caused the node deletion logic in the gc node to not be actually executed.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Nov 8, 2024
@oilbeater
Copy link
Collaborator

@cmdy the u2o e2e failed. Seems like some policy rules get lost.

@cmdy
Copy link
Contributor Author

cmdy commented Nov 8, 2024

@cmdy the u2o e2e failed. Seems like some policy rules get lost.

In release-1.12, e2e test file not found, what should I do to pass the check

@oilbeater
Copy link
Collaborator

It has been backport in b23c8da

@oilbeater oilbeater closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants