Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] When add_eip, send a GARP for eip from net1 #4701

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

kldancer
Copy link

@kldancer kldancer commented Nov 6, 2024

[bugfix] When add_eip, send an ARP packet from net1 to the gateway to announce the EIP to the switch.

Pull Request

What type of this PR

Examples of user facing changes:

  • Bug fixes

Which issue(s) this PR fixes

  1. Restarting nat-gw will cause external access to EIP traffic to be interrupted and will not be automatically restored.
  2. Therefore, when adding add_eip in the nat-gw script, actively send an arp request with src_ip as EIP and sent to the gateway to update the underlying switch arp information.
  3. [BUG] 自定义VPC的Nat-gw pod重启,导致已存在的外部访问EIP的流量断开,且无法自动恢复。 #4690

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Nov 6, 2024
@kldancer
Copy link
Author

kldancer commented Nov 6, 2024

@bobz965 你好👋,有两个自动检查失败了,能帮我看一下是什么原因吗?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 6, 2024
@bobz965
Copy link
Collaborator

bobz965 commented Nov 6, 2024

@bobz965 你好👋,有两个自动检查失败了,能帮我看一下是什么原因吗?

不影响

@kldancer kldancer changed the title [bugfix] When add_eip, send an ARP packet from net1 to the gateway to announce the EIP to the switch. [bugfix] When add_eip, send a GARP for eip from net1 Nov 7, 2024
@kldancer kldancer requested a review from bobz965 November 7, 2024 03:12
@bobz965 bobz965 merged commit 57c8239 into kubeovn:release-1.12 Nov 7, 2024
52 of 55 checks passed
@kldancer kldancer deleted the nat-gw-arp-1.12 branch November 7, 2024 06:09
@hackerain
Copy link
Contributor

arping -D的意思是要去检查是否有IP冲突,把这个去掉不太好吧?

@bobz965
Copy link
Collaborator

bobz965 commented Nov 12, 2024

arping -D的意思是要去检查是否有IP冲突,把这个去掉不太好吧?

看起来没有去掉,新增了一行

@hackerain
Copy link
Contributor

哦哦,sorry,我看错了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants