Disable pod use NodeSwitch subnet #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Longchuanzheng
force-pushed
the
disablepodusejoin
branch
2 times, most recently
from
eb86e48 to
56a98e2
Compare
zbb88888
reviewed
May 8, 2024
|
I find it is difficult to add webhook for pod use join subnet. The name of the "join" subnet is implemented by setting the "node-switch" in ovn-controller. We can not get "node-switch" name in webhook because it dosen't have a controller. |
|
I also think this PR is an inelegant patch, let's see if there is a better solution. |
zbb88888
approved these changes
May 9, 2024
Signed-off-by: zhuanlan <[email protected]>
zbb88888
force-pushed
the
disablepodusejoin
branch
from
56a98e2 to
15b6382
Compare
zbb88888
pushed a commit
that referenced
this pull request
May 13, 2024
Signed-off-by: zhuanlan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #3947