Pytorch documentation for v1beta1 and v1beta2 #545
Conversation
|
/assign @johnugeorge |
|
/assign |
| @@ -0,0 +1,226 @@ | |||
| +++ | |||
There was a problem hiding this comment.
Please would you also add a file at the following location:
content/docs/reference/pytorchjob/v1beta1/_index.md
With file content similar to this one:
https://github.com/kubeflow/website/blob/master/content/docs/reference/tfjob/v1beta1/_index.md
And similar for:
content/docs/reference/pytorchjob/v1beta2/_index.md
These index files will sort out the navigation structure in the left-hand menu of the doc site.
| <td> | ||
| <code>cleanPodPolicy</code></br> | ||
| <em> | ||
| <a href="/docs/reference/tfjob/v1beta1/common/#CleanPodPolicy"> |
There was a problem hiding this comment.
It seems odd to link to a tfjob doc here. Actually, doing a search shows that there are a number of references to tfjob. Is this a copy/paste error?
There was a problem hiding this comment.
This is because the "common" API types are currently part of the tf-operator repository. We have a proposal to move these to a standalone repo: kubeflow/training-operator#960.
|
@sarahmaddox Done |
|
Thanks. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sarahmaddox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change is