-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Model Registry doc to website #3698
add Model Registry doc to website #3698
Conversation
The documentation is to highlight how to onboard users. A component is added to KF website sidebar. Use Alpha version marker. The doc highlight how to install, use Python client, examples of integrations with other components and add-ons. Signed-off-by: Matteo Mortari <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tarilabs. I left a few suggestions.
Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Helber Belmiro <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Helber Belmiro <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Helber Belmiro <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@tarilabs thanks a lot for getting this started! I went through though the current version, I think it's a good first version. First of all a comment on timeline: we do not have to rush this in time for feature freeze. We have a couple more weeks to finetune and improve the docs. So let's keep this PR running until we have a good version. Then, I'll refrain from commenting specific sections and instead provide some higher level feedback:
I know it's a lot. Great documentation takes a lot of time and effort. Let's try and do these things incrementally. I hope that @diegolovison and @hbelmiro can also help out a little bit here. |
ack, and agreed
yes, this was discussed in the KF community-calls, in the KF MR bi-weekly Josh already suggested the same, we're iterating on a google doc already which will be "poured" in content into this PR as soon as the copy is ready
Thanks for the feedback @StefanoFioravanzo ! 📥 ✍️ |
Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
under a "Reference" section Signed-off-by: Matteo Mortari <[email protected]>
...into an Installation page and the "actual" getting-started example guide Signed-off-by: Matteo Mortari <[email protected]>
content/en/docs/components/model-registry/reference/architecture.md
Outdated
Show resolved
Hide resolved
…re.md Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Helber Belmiro <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Andrea Lamparelli <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Andrea Lamparelli <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
as requested in meeting Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
yep thanks again for the feedback @andreyvelich , I addressed most of them, about the remaining kindly let me know if, as discussed previously in this thread, do you require them as part of this PR or could be follow-ed up in subsequent PRs (so as also to "parallelize" changes). Thank you! |
Sure, we can incorporate them in a following PR. Do you want to address this change in the next PR: #3698 (comment) ? |
Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Josh Bottum <[email protected]>
ca29c34
to
84f3859
Compare
Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Josh Bottum <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Josh Bottum <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Josh Bottum <[email protected]>
unless anyone has any "blocker" or "veto" comments, since this PR has been open for a long time (March) and incorporated as many comments as possible in the time being (see thread), I'd be happy to have it merged, and parallelize any further comments/amendments in separate PRs (multiple). Kindly let me know your guidance here, and once again thanks for all who contributed reviews!! |
@andreyvelich: GitHub didn't allow me to assign the following users: for, the, approval. Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbottum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Opening this PR for early feedback.
As feedback received by Release Team during KF community meetings and Model Registry meetings,
As identified in the Model Registry KF 1.9 tracker issue on request by Release Team,
➡️ Documentation is needed for Model Registry alpha on the KF website, as part of the KF 1.9 deliverables by Model Registry wg.
This PR focus on the following received requests:
This documentations is loosely based on the content presented with this demo.