Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Training] Add the guide on how to use Scheduler Plugins with coscheduling #3432

Merged
merged 1 commit into from
Jan 21, 2023
Merged

[Training] Add the guide on how to use Scheduler Plugins with coscheduling #3432

merged 1 commit into from
Jan 21, 2023

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jan 21, 2023 •
edited
Loading

Signed-off-by: Yuki Iwai [email protected]

I added the guide on how to use Scheduler Plugins with coscheduling.

@google-oss-prow google-oss-prow bot requested review from 8bitmp3 and jinchihe January 21, 2023 14:40
@tenzen-y
Copy link
Member Author

/hold for kubeflow/training-operator#1724

@tenzen-y tenzen-y force-pushed the add-coscheduling-plugin branch 3 times, most recently from d79a9c0 to b52f343 Compare January 21, 2023 14:53
@tenzen-y
Copy link
Member Author

/assign @kubeflow/wg-training-leads

@tenzen-y tenzen-y force-pushed the add-coscheduling-plugin branch from b52f343 to 196cd3b Compare January 21, 2023 14:57
@tenzen-y tenzen-y changed the title [Training] Add the guide on how to use Scheduler Plugins with coscheduling plugin [Training] Add the guide on how to use Scheduler Plugins with coscheduling Jan 21, 2023
@johnugeorge
Copy link
Member

Thanks for updating docs

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jan 21, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member Author

/hold cancel

@google-oss-prow google-oss-prow bot merged commit 2f340ad into kubeflow:master Jan 21, 2023
@tenzen-y tenzen-y deleted the add-coscheduling-plugin branch January 21, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8bitmp3 8bitmp3 Awaiting requested review from 8bitmp3

@jinchihe jinchihe Awaiting requested review from jinchihe

Assignees

@johnugeorge johnugeorge

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tenzen-y @johnugeorge