Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for XGBoost #2965

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

pramodrj07
Copy link
Contributor

  1. Add the name of 'XGBoost' crd in title
  2. Add command to fetch pods explicitly in 'kubeflow' namespace

These changes are aimed to improve the readability of the XGBoost page
and also to catch up with latest doc changes of others like MXNet,
pytorch

1. Add the name of 'XGBoost' crd in title
2. Add command to fetch pods explicitly in 'kubeflow' namespace

These changes are aimed to improve the readability of the XGBoost page
and also to catch up with latest doc changes of others like MXNet,
pytorch
@google-oss-robot
Copy link

Hi @pramodrj07. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pramodrj07
Copy link
Contributor Author

/assign @terrytangyuan

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pramodrj07, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit cbcb699 into kubeflow:master Sep 21, 2021
pramodrj07 added a commit to pramodrj07/internal-acls that referenced this pull request Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants