Update TFJob docs with information about monitoring. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move over the documentation in kubeflow/tf-operator/README.md and update it for v1alpha2. * Add a what is TFJob section that describes the TFJob * Provide information about the spec * Provide information about exit codes. * Provide stackdriver sections for both the legacy and new Kubernetes stackdriver. * Add a troubleshooting section.
jlewi
added a commit
to jlewi/k8s
that referenced
this pull request
Jul 29, 2018
* We should direct users to the official documentation and remove the documentation in the README.md * kubeflow/website#107 will update the website to include all information currently in the README as well as other information * README.md is outdated; e.g. it is still referring to v1alpha1 Fix kubeflow#760
|
/assign @kunmingg |
k8s-ci-robot
pushed a commit
to kubeflow/training-operator
that referenced
this pull request
Jul 30, 2018
* We should direct users to the official documentation and remove the documentation in the README.md * kubeflow/website#107 will update the website to include all information currently in the README as well as other information * README.md is outdated; e.g. it is still referring to v1alpha1 Fix #760
abhi-g
reviewed
Aug 1, 2018
| @@ -74,14 +204,14 @@ Typically you will want to change the following values | |||
|
|
|||
| 1. Attach PV's if you want to use PVs for storage. | |||
|
|
|||
| ## Submitting a TensorFlow training job | |||
| ### Submitting a TensorFlow training job | |||
There was a problem hiding this comment.
Lines 207 - 271 seem to be duplicate of lines 143-206.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move over the documentation in kubeflow/tf-operator/README.md and
update it for v1alpha2.
Add a what is TFJob section that describes the TFJob
Provide stackdriver sections for both the legacy and new Kubernetes
stackdriver.
Add a troubleshooting section.
This change is