-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an e2etest for testing restart policy #873
Conversation
/hold |
/test kubeflow-tf-operator-presubmit |
Thanks for your contribution! Feel free to assign me or richardsliu to review. |
@gaocegege |
/retest |
/hold cancel |
/assign @gaocegege @richardsliu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\lgtm
While I think we need @richardsliu 's opinion.
@richardsliu We can only review https://github.com/kubeflow/tf-operator/pull/873/files#diff-bb0480aabc8947b0a59583d963fd9f31R1
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing!
/retest |
@richardsliu |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardsliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #639
This PR does the following things:
labels["tf-replica-type"] = replica_type
tolabels["tf-replica-type"] = str.lower(replica_type)
This change is