delete pdb when tfjob is terminated #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @gaocegege |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Travis tests have failedHey @ChanYiLin, 2nd Buildgometalinter --config=linter_config.json --vendor ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go"3rd Buildgometalinter --config=linter_config.json --vendor ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go" |
gaocegege
reviewed
Jul 10, 2018
| ) | ||
|
|
There was a problem hiding this comment.
I think we could keep the line
| terminatedTFJobReason = "TFJobTerminated" | ||
| failedMarshalTFJobReason = "FailedMarshalTFJob" | ||
| terminatedTFJobReason = "TFJobTerminated" | ||
| FailedDeletePdbReason = "FailedDeletePdb" |
There was a problem hiding this comment.
We do not to keep the variables public, IMO
There was a problem hiding this comment.
Ok, I will revised it!
And I found I have some bug in my code, I will also fix them first
There was a problem hiding this comment.
@gaocegege I think I have corrected all the small bugs, thanks
|
/ok-to-test Only some nits |
Travis tests have failedHey @ChanYiLin, 2nd Buildgometalinter --config=linter_config.json --vendor ./...3rd Buildgometalinter --config=linter_config.json --vendor ./... |
Travis tests have failedHey @ChanYiLin, 2nd Buildgometalinter --config=linter_config.json --vendor ./...3rd Buildgometalinter --config=linter_config.json --vendor ./... |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, we should also delete pdb when tfjob is terminated.
This change is