Create a script to release the TFJob operator image #515
Conversation
* Add a script to submit the Argo workflow.
|
/uncc @lluunn |
jlewi
changed the title
|
Done. |
submit_release_job.sh
Outdated
| PROW_VAR="${PROW_VAR},REPO_OWNER=${REPO_OWNER},BUILD_NUMBER=${BUILD_NUMBER}" | ||
| PROW_VAR="${PROW_VAR},PULL_BASE_SHA=${PULL_BASE_SHA}" | ||
|
|
||
| cd test/workflows |
There was a problem hiding this comment.
nit: maybe cd $(git rev-parse --show-toplevel)/test/workflows so developers could run this from anywhere in the tree (or keep it in their PATH, even).
|
@willb Its definitely doable but I think that falls into the bucket of how to further improve the tooling around releases. |
* Update the submit_release_job.sh so it can run from anywhere in the tree.
|
@jlewi agreed that this shouldn’t block on having the script run in CI; I’ll file an issue for a future release. The script changes look good; thanks! /lgtm |
|
/lgtm |
|
/retest |
|
/approve |
|
@jlewi: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal, gaocegege, jlewi, willb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Create instructions for doing a release of TFJob operator docker image * Add a script to submit the Argo workflow. * * Add instructions for how to do a release. * Update the submit_release_job.sh so it can run from anywhere in the tree. * * Get the root directory based on the script.
Add a script to submit the Argo workflow.
Related to
kubeflow/kubeflow#215
This change is