-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python lint tests. #362
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Hi @nanliu. Thanks for your PR. I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #53 |
Thanks for the contribution. We already run pylint in prow. And I think we are already running gotomelinter in travis. What is the remaining work to do with fix lint? |
Ah, I wasn't aware of that. If it's no longer an issue feel free to close the PR and issue. I was doing something quick to check if my cla is working. Looks like I have to go track down some stuff on my end with our corporate cla. |
.travis.yml
Outdated
# For now though we just run all tests in pkg. | ||
- $GOPATH/bin/goveralls -service=travis-ci -v -package ./pkg/... | ||
- language: python | ||
python: 2.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we please use 3.6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After toggling it, I just remember the lint results are not very happy in 3.6 with a bunch of deprecation warnings, so I assumed the project was set to 2.7.
I took a look at #53 and added some notes about what's missing. For py it looks like we are missing pep8 check. If you wanted to add pep8 check you could add it to our existing run_lint function That way it would be automatically invoked by prow and reported in prow (as opposed to using travis). markdown autoformatting would be super nice as well. I think I'm seeing a lot of spurious changes in markdown PRs because everyone formats files differently. So would be really nice to start defining some standard conventions to cut this down. |
I signed it! |
This change is