-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setting defaults. #299
Conversation
* Need to register the default functions. * In setup we need to invoke setting the defaults on the objects. * This fixes a break introduced when we refactored the code.
The job in prow is weird: https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/tensorflow_k8s/299/tf-k8s-presubmit/354/
|
@jlewi Sorry for the mistake and Thanks for your fix. Can we keep style with k8s and add function below:
|
@wackxu NP. What file is the init function in? |
@jlewi The one you modifed |
@wackxu PTAL |
/lgtm |
@jlewi Seems there have an gometalinter error, just run
|
// generated functions takes place in the generated files. The separation | ||
// makes the code compile even when the generated files are missing. | ||
SchemeBuilder.Register(addDefaultingFuncs) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add addKnownTypes
here:
SchemeBuilder.Register(addKnownTypes)
And here https://github.com/tensorflow/k8s/pull/299/files#diff-2f7eaaeac6f6da3e4c93e8530a8a4e4aL10 should be:
SchemeBuilder runtime.SchemeBuilder
I think it may be clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wackxu ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not think so, I think now is better and there is nothing that are confuse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, then LGTM
And this PR also fixes #297 |
This change is