Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types.go: Fix CRDKind #276

Merged
merged 1 commit into from
Jan 10, 2018
Merged

types.go: Fix CRDKind #276

merged 1 commit into from
Jan 10, 2018

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Jan 10, 2018

Close #274

I am not sure why the typo is not reported by our tests.

And, besides this, I found another error after this patch:

ERROR: logging before flag.Parse: I0110 16:52:24.938826    3707 controller.go:117] Starting TfJob controller
ERROR: logging before flag.Parse: I0110 16:52:24.938863    3707 controller.go:120] Waiting for informer caches to sync
ERROR: logging before flag.Parse: E0110 16:52:24.998866    3707 runtime.go:66] Observed a panic: &errors.errorString{s:"*v1alpha1.TfJobList does not implement the List interface"} (*v1alpha1.TfJobList does not implement the List interface)

Signed-off-by: Ce Gao [email protected]


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @gaocegege. Thanks for your PR.

I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

coveralls commented Jan 10, 2018

Coverage Status

Coverage remained the same at 30.446% when pulling 868b952 on gaocegege:name into 9c93d5f on tensorflow:master.

@zjj2wry
Copy link
Member

zjj2wry commented Jan 10, 2018

/ok-to-test

@gaocegege
Copy link
Member Author

PTAL

Copy link
Member

@zjj2wry zjj2wry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jlewi
Copy link
Contributor

jlewi commented Jan 10, 2018

What was the behavior that caused an error to be triggered?
Can you file a bug to create a test to cover this?

@jlewi jlewi merged commit adc8ab9 into kubeflow:master Jan 10, 2018
@gaocegege
Copy link
Member Author

@jlewi Do you mean the bug #274 or the new error *v1alpha1.TfJobList does not implement the List interface

@jlewi
Copy link
Contributor

jlewi commented Jan 10, 2018

I filed #280.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants