-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move around due to new directories layout #273
Conversation
Hi @ScorpioCPH. Thanks for your PR. I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Looks good. Just waiting to see if the tests pass. |
@jlewi Sorry, |
Here are the logs |
I don't actually see the build/ dir in the repo so I think the files build/images/... are actually missing from the PR. Looks like build/ is ignored by .gitignore. |
I was looking around to see what other projects do. I actually like that as it means the image leaves close to the directory. Could we do the same thing and |
@jlewi Maybe it's a little weird putting some Dockerfiles in Like kuberneres repo, there is a build directory for Dockerfiles. I will take a look at gitignore. And another thing: can we attach the building logs in the details link? so PR author can debug the building errors. |
I don't feel too strongly about the location. If you think build is best I can live with that. Short answer is the test infrastructure is a pain point and its something I plan on fixing.
But this is blocked on migrating off Airflow to Argo. Its not worth fixing with Airflow since I want to get rid of Airflow. |
0a33567
to
f0b63ee
Compare
@jlewi Hi, is there any thing i can help about e2e stuff? I'm happy to take a look at this :) |
We need to get #293 fixed before we can trust the tests again. |
f0b63ee
to
5639c39
Compare
5639c39
to
47aec7d
Compare
@jlewi Tests passed, PTAL, thanks! |
Head should be fixed. Can you sync and push so the tests rerun? |
/test all |
47aec7d
to
8863936
Compare
As proposed here: #261
This PR move folders around to match new directories layout with nothing changed.
@jlewi PTAL, Thanks!
This change is