-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-2170: Strictly verify the CRD marker validation and defaulting in the integration testings #2304
KEP-2170: Strictly verify the CRD marker validation and defaulting in the integration testings #2304
Conversation
/hold |
@tenzen-y: GitHub didn't allow me to request PR reviews from the following users: akshaychitneni. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 11489327226Details
💛 - Coveralls |
… integration testings Signed-off-by: Yuki Iwai <[email protected]>
d0f18be
to
719a6f1
Compare
func BeForbiddenError() types.GomegaMatcher { | ||
return BeAPIError(ForbiddenError) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we could return this error ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will use this in webhook impl similar to
allErrs = append(allErrs, field.Forbidden(elasticNProcPerNodePath, fmt.Sprintf("must not be used with %s", nprocPerNodePath))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tenzen-y
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What this PR does / why we need it:
I refactored the CRD marker integration testing so that we could more strictly verify the expected behavior.
Additionally, I made the
.spec.runtimeRef
field as immutable field to reduce unexpected errors when actual Jobs are built.Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #2293
Relates to #2170
Checklist: