-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JAX controller #2194
Add JAX controller #2194
Conversation
Pull Request Test Coverage Report for Build 10960403998Details
💛 - Coveralls |
@sandipanpanda - Is this PR ready for review? |
Actually, no. @sandipanpanda continues trying some implementations. |
cbb0ae0
to
cf76911
Compare
Adding jaxjob webhook test, examples and finishing up some work on test_e2e_jaxjob.py remain. Can you please share your input if the current implementation up until now is in the correct direction? |
@sandipanpanda If this PR is ready for review, please review the WIP from the PR title. |
a5e554b
to
4c266aa
Compare
4c266aa
to
212f8bf
Compare
212f8bf
to
8e995a7
Compare
@sandipanpanda Could you address this error? We need to pass the appropriate arguments to e2e testing.
|
a3303b7
to
f957d69
Compare
cc @tenzen-y PTAL |
9effb4a
to
7c0563d
Compare
Add JAX controller, controller tests, webhook validations, examples, e2e tests for JAXJob Extend the Training Operator Python SDK to simplify the creation and management of JAXJob resources. Signed-off-by: Sandipan Panda <[email protected]>
7c0563d
to
9219e94
Compare
9219e94
to
78623e1
Compare
Signed-off-by: Sandipan Panda <[email protected]>
78623e1
to
32aad29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for a lot of work!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for your unwavering guidance and support throughout this project! |
What this PR does / why we need it:
Implement JAX controller
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fix: #1619
Ref:#2145
/area gsoc