Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kubernetes dependencies to v1.26 #1817

Merged
merged 1 commit into from
May 31, 2023

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented May 31, 2023

What this PR does / why we need it:
I upgraded kubernetes dependencies to v1.26.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Part-of #1803

Checklist:

  • Docs included if any changes are user facing

@tenzen-y
Copy link
Member Author

blocked on #1818

@tenzen-y tenzen-y force-pushed the upgrade-k8s-v1.26 branch from 64c9ceb to 46f93d5 Compare May 31, 2023 14:13
@coveralls
Copy link

coveralls commented May 31, 2023

Pull Request Test Coverage Report for Build 5133950363

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 33.882%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 77.22%
pkg/controller.v1/pytorch/pytorchjob_controller.go 9 58.19%
Totals Coverage Status
Change from base Build 5133911112: 0.02%
Covered Lines: 3333
Relevant Lines: 9837

💛 - Coveralls

@tenzen-y
Copy link
Member Author

These are new flaky tests... Since those cases work well on my local :(

@johnugeorge
Copy link
Member

Somehow, these flaky tests were not seen earlier.

@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1bb8da0 into kubeflow:master May 31, 2023
@tenzen-y
Copy link
Member Author

Somehow, these flaky tests were not seen earlier.

Uhm... I will investigate the root cause.

@tenzen-y tenzen-y deleted the upgrade-k8s-v1.26 branch May 31, 2023 17:17
@tenzen-y
Copy link
Member Author

Created: #1820 #1821 #1822

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants