GetPodsForJob check the pod owner reference job uid

[yowenter]

What this PR does / why we need it:
If job is recreated using the deleted job name while the deleted job pods are stuck in Terminating state , the func GetPodsForJob maybe incorrect.

Checklist:

• Docs included if any changes are user facing

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[yowenter]

Hi, @tenzen-y (friendly ping ), Could you please have a look ?

[tenzen-y]

Thank you for this improvement!
I left a few comments.

[yowenter]

Hi, @tenzen-y , I've made some changes, please review again.
And there's also a pull request Pod name using generated name to fix recreated job using the same name issue. Could you review it if you have time?

[tenzen-y]

/lgtm
Thanks for your contribution. I'm looking forward to collaborating more in the future.

/assign @johnugeorge @gaocegege @terrytangyuan

[tenzen-y]

And there's also a pull request kubeflow/common#215 to fix recreated job using the same name issue. Could you review it if you have time?

Maybe, I can't review the PR this week since there are many PRs in my review queue.
Thanks for your patience.

[yowenter]

And there's also a pull request kubeflow/common#215 to fix recreated job using the same name issue. Could you review it if you have time?

Maybe, I can't review the PR this week since there are many PRs in my review queue. Thanks for your patience.

it’s okay, take your time.

[tenzen-y]

/lgtm

[coveralls]

Pull Request Test Coverage Report for Build 4819195351

• 5 of 11 (45.45%) changed or added relevant lines in 7 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.02%) to 39.437%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/controller.v1/mxnet/mxjob_controller.go	0	1	0.0%
pkg/controller.v1/xgboost/xgboostjob_controller.go	0	1	0.0%
pkg/common/util/util.go	0	4	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/controller.v1/mpi/mpijob_controller.go	2	76.84%

Totals
Change from base Build 4659763896:	-0.02%
Covered Lines:	2731
Relevant Lines:	6925

---

💛 - Coveralls

[johnugeorge]

Thanks for cleaning this up @yowenter
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, yowenter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [johnugeorge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment