Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Upgrade some actions version #1686

Merged

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Nov 3, 2022

Signed-off-by: tenzen-y [email protected]

What this PR does / why we need it:
To resolve the following warning, I upgraded the following actions:

  • actions/checkout -> v3
  • docker/metadata-action -> v4
  • docker/setup-buildx-action -> v2
  • docker/login-action -> v2
  • docker/build-push-action -> v3
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, docker/setup-buildx-action, docker/login-action, docker/metadata-action, docker/build-push-action, docker/build-push-action, docker/login-action, docker/setup-buildx-action, actions/checkout

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Nov 3, 2022

Pull Request Test Coverage Report for Build 3383757834

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 39.527%

Totals Coverage Status
Change from base Build 3380673253: -0.2%
Covered Lines: 2340
Relevant Lines: 5920

💛 - Coveralls

@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnugeorge
Copy link
Member

/lgtm cancel

@google-oss-prow google-oss-prow bot removed the lgtm label Nov 3, 2022
@johnugeorge
Copy link
Member

@tenzen-y metadata-action also needs to be upgraded?

@tenzen-y
Copy link
Member Author

tenzen-y commented Nov 3, 2022

@tenzen-y metadata-action also needs to be upgraded?

Yes, we also need to upgrade docker/metadata-action version. I will push changes to this PR soon.

@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Nov 3, 2022
@tenzen-y
Copy link
Member Author

tenzen-y commented Nov 3, 2022

@johnugeorge Pushed.

@tenzen-y tenzen-y changed the title [chore] Upgrade actions/checkout version to v3 [chore] Upgrade actions/checkout and docker/metadata-action version Nov 3, 2022
@tenzen-y
Copy link
Member Author

tenzen-y commented Nov 3, 2022

/hold

@tenzen-y
Copy link
Member Author

tenzen-y commented Nov 3, 2022

We need to upgrade other actions.

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, docker/setup-buildx-action, docker/login-action, docker/metadata-action, docker/build-push-action, docker/build-push-action, docker/login-action, docker/setup-buildx-action, actions/checkout

@tenzen-y tenzen-y changed the title [chore] Upgrade actions/checkout and docker/metadata-action version [chore] Upgrade some actions version Nov 3, 2022
@tenzen-y
Copy link
Member Author

tenzen-y commented Nov 3, 2022

/hold cancel

@johnugeorge I pushed all changes. PTAL

@johnugeorge
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Nov 3, 2022
@google-oss-prow google-oss-prow bot merged commit 3697115 into kubeflow:master Nov 3, 2022
@tenzen-y tenzen-y deleted the upgrade-actions-checkout-version branch November 3, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants