-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Upgrade some actions version #1686
[chore] Upgrade some actions version #1686
Conversation
Signed-off-by: tenzen-y <[email protected]>
Pull Request Test Coverage Report for Build 3383757834
💛 - Coveralls |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm cancel |
@tenzen-y metadata-action also needs to be upgraded? |
Yes, we also need to upgrade docker/metadata-action version. I will push changes to this PR soon. |
Signed-off-by: tenzen-y <[email protected]>
@johnugeorge Pushed. |
/hold |
We need to upgrade other actions. Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, docker/setup-buildx-action, docker/login-action, docker/metadata-action, docker/build-push-action, docker/build-push-action, docker/login-action, docker/setup-buildx-action, actions/checkout |
Signed-off-by: tenzen-y <[email protected]>
/hold cancel @johnugeorge I pushed all changes. PTAL |
/lgtm |
Signed-off-by: tenzen-y [email protected]
What this PR does / why we need it:
To resolve the following warning, I upgraded the following actions:
actions/checkout
-> v3docker/metadata-action
-> v4docker/setup-buildx-action
-> v2docker/login-action
-> v2docker/build-push-action
-> v3Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: