-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused scripts #1521
remove unused scripts #1521
Conversation
improve status_test from tensorflow
Skipping CI for Draft Pull Request. |
Pull Request Test Coverage Report for Build 1673998083
💛 - Coveralls |
@@ -17,8 +17,6 @@ package v1 | |||
import common "github.com/kubeflow/common/pkg/apis/common/v1" | |||
|
|||
const ( | |||
// EnvKubeflowNamespace is ENV for kubeflow namespace specified by user. | |||
EnvKubeflowNamespace = "KUBEFLOW_NAMESPACE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember this was the default. So this isn't used anywhere anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems not. Let's see scripts below:
lucas@Wangs-MacBook-Pro-at-Tencent > /tmp/training-operator-master > grep -rin "KUBEFLOW_NAMESPACE" .
./docs/development/developer_guide.md:47:### Configure KUBECONFIG and KUBEFLOW_NAMESPACE
./docs/development/developer_guide.md:54:export KUBEFLOW_NAMESPACE=$(your_namespace)
./docs/development/developer_guide.md:57:- KUBEFLOW_NAMESPACE is used when deployed on Kubernetes, we use this variable to create other resources (e.g. the resource lock) internal in the same namespace. It is optional, use `default` namespace if not set.
./pkg/apis/mpi/v1/constants.go:21: EnvKubeflowNamespace = "KUBEFLOW_NAMESPACE"
./pkg/common/constants.go:19: EnvKubeflowNamespace = "KUBEFLOW_NAMESPACE"
lucas@Wangs-MacBook-Pro-at-Tencent > /tmp/training-operator-master > grep -rin "EnvKubeflowNamespace" .
./pkg/apis/mpi/v1/constants.go:20: // EnvKubeflowNamespace is ENV for kubeflow namespace specified by user.
./pkg/apis/mpi/v1/constants.go:21: EnvKubeflowNamespace = "KUBEFLOW_NAMESPACE"
./pkg/common/constants.go:18: // EnvKubeflowNamespace is ENV for kubeflow namespace specified by user.
./pkg/common/constants.go:19: EnvKubeflowNamespace = "KUBEFLOW_NAMESPACE"
I double checked with v1.2.0 and EnvKubeflowNamespace
is used there. It seems the transition results in a change in the main
function, which lost this option. But we can still remove it here as it's also defined in the kubeflow/common
library: https://github.com/kubeflow/common/blob/97658773cce10b2b706e38858e48137ae370ed10/pkg/util/util.go#L31
I open another issue to restore these options: #1522
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan, zw0610 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
improve status_test from tensorflow
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #
Checklist:
SetServicesV2
back toSetServices
register_controller.go