Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Python SDK installation command #1438

Closed

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Oct 7, 2021

The package is not in PyPI so pip install kubeflow-training won't work and the best way to install is from Git with subdirectory=sdk/python.

Signed-off-by: Yuan Tang [email protected]

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -9,7 +9,8 @@ Python 2.7 and 3.5+
### pip install

```sh
pip install kubeflow-training
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the plan is to have this package avialable in pypi but I am not the original process. Jinchi owned this part.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this is in the README though so users would expect this to just work. We should only install from PyPI directly when it’s available.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jeffwan, @terrytangyuan I published the package to testing PyPI for everyone to try it out:
https://test.pypi.org/project/kubeflow-training/
It can be installed and tested from there. When we are ready, let's publish it to the PyPI. I would propose to prioritize publishing it, so the doc update is not needed.
Please let me know in case I can help with releasing it to PyPI.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can provide instructions on both so as soon as the package is on PyPI we can add that instruction.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need additional time to test it out to avoid issues like #1439 so it’s better to provide instruction that’s working now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought sdk test case should catch that issue. not sure why it didn't. anyway, I can spend some time on the testing this weekend. After the verification, we can publish it officially and we don't need this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@terrytangyuan
Copy link
Member Author

Closing as no longer needed

@terrytangyuan terrytangyuan deleted the fix-sdk-install-cmd branch October 17, 2021 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants