Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Move myself to approvers #1419

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

terrytangyuan
Copy link
Member

Signed-off-by: Yuan Tang [email protected]

@Jeffwan
Copy link
Member

Jeffwan commented Sep 22, 2021

@terrytangyuan helps a lot on OSS management, common code base and and owns MXNet/XGboost/MPI part. +1. Hold for other reviewers.

/lgtm
/hold

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great work @terrytangyuan!
/lgtm

@gaocegege
Copy link
Member

/lgtm

@terrytangyuan
Copy link
Member Author

/hold cancel

@gaocegege
Copy link
Member

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit acba15e into kubeflow:master Sep 23, 2021
@terrytangyuan terrytangyuan deleted the mv-owners branch September 23, 2021 02:56
@terrytangyuan
Copy link
Member Author

Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants