Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1322: Modified manifests to use all-in-one training-operator #1346

Merged
8 changes: 4 additions & 4 deletions manifests/base/cluster-role-binding.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ apiVersion: rbac.authorization.k8s.io/v1beta1
kind: ClusterRoleBinding
metadata:
labels:
app: tf-job-operator
name: tf-job-operator
app: training-operator
name: training-operator
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: tf-job-operator
name: training-operator
subjects:
- kind: ServiceAccount
name: tf-job-operator
name: training-operator
14 changes: 7 additions & 7 deletions manifests/base/cluster-role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ apiVersion: rbac.authorization.k8s.io/v1beta1
kind: ClusterRole
metadata:
labels:
app: tf-job-operator
name: tf-job-operator
app: training-operator
name: training-operator
rules:
- apiGroups:
- kubeflow.org
Jeffwan marked this conversation as resolved.
Show resolved Hide resolved
Expand Down Expand Up @@ -48,24 +48,24 @@ rules:
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: kubeflow-tfjobs-admin
name: kubeflow-training-admin
labels:
rbac.authorization.kubeflow.org/aggregate-to-kubeflow-admin: "true"
aggregationRule:
clusterRoleSelectors:
- matchLabels:
rbac.authorization.kubeflow.org/aggregate-to-kubeflow-tfjobs-admin: "true"
rbac.authorization.kubeflow.org/aggregate-to-kubeflow-training-admin: "true"
rules: []

---

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: kubeflow-tfjobs-edit
name: kubeflow-training-edit
labels:
rbac.authorization.kubeflow.org/aggregate-to-kubeflow-edit: "true"
rbac.authorization.kubeflow.org/aggregate-to-kubeflow-tfjobs-admin: "true"
rbac.authorization.kubeflow.org/aggregate-to-kubeflow-training-admin: "true"
rules:
- apiGroups:
deepak-muley marked this conversation as resolved.
Show resolved Hide resolved
- kubeflow.org
Expand All @@ -87,7 +87,7 @@ rules:
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: kubeflow-tfjobs-view
name: kubeflow-training-view
labels:
rbac.authorization.kubeflow.org/aggregate-to-kubeflow-view: "true"
rules:
Expand Down
52 changes: 0 additions & 52 deletions manifests/base/crd.yaml

This file was deleted.

6,906 changes: 6,906 additions & 0 deletions manifests/base/crd_mxjobs.yaml

Large diffs are not rendered by default.

6,900 changes: 6,900 additions & 0 deletions manifests/base/crd_pytorchjobs.yaml

Large diffs are not rendered by default.

6,907 changes: 6,907 additions & 0 deletions manifests/base/crd_tfjobs.yaml

Large diffs are not rendered by default.

6,896 changes: 6,896 additions & 0 deletions manifests/base/crd_xgboostjobs.yaml

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions manifests/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: tf-job-operator
name: training-operator
spec:
replicas: 1
template:
metadata:
labels:
name: tf-job-operator
name: training-operator
annotations:
sidecar.istio.io/inject: "false"
spec:
Expand All @@ -24,6 +24,6 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.name
image: public.ecr.aws/j1r0q0g6/training/tf-operator
name: tf-job-operator
serviceAccountName: tf-job-operator
image: public.ecr.aws/j1r0q0g6/training/training-operator
name: training-operator
serviceAccountName: training-operator
23 changes: 13 additions & 10 deletions manifests/base/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,17 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namespace: kubeflow
resources:
- crd.yaml
- cluster-role-binding.yaml
- cluster-role.yaml
- deployment.yaml
- service-account.yaml
- service.yaml
- crd_tfjobs.yaml
- crd_mxjobs.yaml
- crd_pytorchjobs.yaml
- crd_xgboostjobs.yaml
- cluster-role-binding.yaml
- cluster-role.yaml
- deployment.yaml
- service-account.yaml
- service.yaml
commonLabels:
app: tf-job-operator
kustomize.component: tf-job-operator
app.kubernetes.io/component: tfjob
app.kubernetes.io/name: tf-job-operator
app: training-operator
kustomize.component: training-operator
app.kubernetes.io/component: kubeflow-training
app.kubernetes.io/name: training-operator
deepak-muley marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 2 additions & 2 deletions manifests/base/service-account.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ apiVersion: v1
kind: ServiceAccount
metadata:
labels:
app: tf-job-operator
name: tf-job-operator
app: training-operator
name: training-operator
6 changes: 3 additions & 3 deletions manifests/base/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ metadata:
prometheus.io/scrape: "true"
prometheus.io/port: "8443"
labels:
app: tf-job-operator
name: tf-job-operator
app: training-operator
name: training-operator
spec:
ports:
- name: monitoring-port
port: 8443
targetPort: 8443
selector:
name: tf-job-operator
name: training-operator
type: ClusterIP
15 changes: 7 additions & 8 deletions manifests/overlays/kubeflow/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namespace: kubeflow
resources:
- ../../base
- ../../base
commonLabels:
app: tf-job-operator
kustomize.component: tf-job-operator
app.kubernetes.io/component: tfjob
app.kubernetes.io/name: tf-job-operator
app: training-operator
kustomize.component: training-operator
app.kubernetes.io/component: kubeflow-training
app.kubernetes.io/name: training-operator
Jeffwan marked this conversation as resolved.
Show resolved Hide resolved
images:
- name: public.ecr.aws/j1r0q0g6/training/tf-operator
newTag: 47a74b738920edbf4207160cec7e1dff9cdab3f2

- name: public.ecr.aws/j1r0q0g6/training/training-operator
newTag: cd2fc1ff397b1f349f68524f4abd5013a32e3033
17 changes: 8 additions & 9 deletions manifests/overlays/standalone/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namespace: kubeflow
resources:
- ../../base
- namespace.yaml
- ../../base
- namespace.yaml
commonLabels:
app: tf-job-operator
kustomize.component: tf-job-operator
app.kubernetes.io/component: tfjob
app.kubernetes.io/name: tf-job-operator
app: training-operator
kustomize.component: training-operator
app.kubernetes.io/component: kubeflow-training
app.kubernetes.io/name: training-operator
deepak-muley marked this conversation as resolved.
Show resolved Hide resolved
images:
- name: public.ecr.aws/j1r0q0g6/training/tf-operator
newTag: 47a74b738920edbf4207160cec7e1dff9cdab3f2

- name: public.ecr.aws/j1r0q0g6/training/training-operator
newTag: cd2fc1ff397b1f349f68524f4abd5013a32e3033
15 changes: 0 additions & 15 deletions manifests/overlays/standalone_v2/kustomization.yaml

This file was deleted.

4 changes: 0 additions & 4 deletions manifests/overlays/standalone_v2/namespace.yaml

This file was deleted.