Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ppc64le support for the example dist-mnist #1084

Merged
merged 1 commit into from
Sep 16, 2019
Merged

add ppc64le support for the example dist-mnist #1084

merged 1 commit into from
Sep 16, 2019

Conversation

alongzhi
Copy link
Contributor

@alongzhi alongzhi commented Sep 12, 2019 •
edited by jlewi
Loading

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @alongzhi. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alongzhi
Copy link
Contributor Author

/cc @jinchihe

@coveralls
Copy link

coveralls commented Sep 12, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 96.512% when pulling 635728f on alongzhi:dist-mnist-ppc64le into 9f6f422 on kubeflow:master.

jinchihe
jinchihe reviewed Sep 12, 2019
View reviewed changes
examples/v1/dist-mnist/Dockerfile.ppc64le Outdated
FROM ibmcom/tensorflow-ppc64le:1.13.1

ADD . /var/tf_dist_mnist
ENTRYPOINT ["python", "/var/tf_dist_mnist/dist_mnist.py"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new line.

examples/v1/dist-mnist/Dockerfile.ppc64le Outdated
@@ -0,0 +1,18 @@
# Copyright 2016 The TensorFlow Authors. All Rights Reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to Kubeflow Authors.

examples/v1/dist-mnist/README.md Outdated
```shell
docker build -f Dockerfile -t kubeflow/tf-dist-mnist-test:1.0 ./
```
If on ppc64le, build as example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To build this image on ppc64le

@jinchihe
Copy link
Member

/ok-to-test

@alongzhi
Copy link
Contributor Author

@jinchihe Updated.

gaocegege
gaocegege reviewed Sep 16, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for your contribution! 🎉 👍

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fdcb897 into kubeflow:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinchihe jinchihe jinchihe left review comments

@gaocegege gaocegege gaocegege left review comments

@ChanYiLin ChanYiLin Awaiting requested review from ChanYiLin

@cheyang cheyang Awaiting requested review from cheyang

Assignees

@gaocegege gaocegege

Labels
approved lgtm ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alongzhi @k8s-ci-robot @coveralls @jinchihe @gaocegege