Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: When executing tf-operator.v1 -version, GitSHA is always 'not provided' #1046

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

asdfsx
Copy link
Contributor

@asdfsx asdfsx commented Jul 18, 2019

After fix a small bug in release scripts, the git commit id can be set into GitSHA variable.
The GitSHA is not 'Not provided' anymore.


This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from jimexist and wackxu July 18, 2019 05:43
@k8s-ci-robot
Copy link

Hi @asdfsx. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

coveralls commented Jul 18, 2019

Coverage Status

Coverage remained the same at 76.744% when pulling 0a20eef on asdfsx:update-release-scripts into eb02785 on kubeflow:master.

@gaocegege
Copy link
Member

/ok-to-test

Thanks for your contribution! 🎉 👍

It bothers us several weeks.

/assign @richardsliu

@asdfsx asdfsx force-pushed the update-release-scripts branch from cd54dd2 to 0a20eef Compare July 19, 2019 02:27
@asdfsx
Copy link
Contributor Author

asdfsx commented Jul 19, 2019

/retest

@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f261e83 into kubeflow:master Jul 19, 2019
@asdfsx asdfsx deleted the update-release-scripts branch July 19, 2019 06:23
ChenYi015 pushed a commit to ChenYi015/training-operator that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants