Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to add CoreV1 to scheme #1037

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Minor fix to add CoreV1 to scheme #1037

merged 1 commit into from
Jul 16, 2019

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Jun 27, 2019

CoreV1 scheme is added as in v1beta2 version


This change is Reviewable

@johnugeorge
Copy link
Member Author

/retest

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.744% when pulling baba49d on johnugeorge:corev1 into d746bde on kubeflow:master.

@johnugeorge
Copy link
Member Author

/retest

1 similar comment
@johnugeorge
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member Author

johnugeorge commented Jun 28, 2019

/hold
till 0.6 release

@gaocegege
Copy link
Member

/hold
/lgtm

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2ae2f6b into kubeflow:master Jul 16, 2019
ChenYi015 pushed a commit to ChenYi015/training-operator that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants