Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not ignore DeletedFinalStateUnknown event when delete pod #1015

Merged
merged 1 commit into from
May 28, 2019
Merged

do not ignore DeletedFinalStateUnknown event when delete pod #1015

merged 1 commit into from
May 28, 2019

Conversation

wackxu
Copy link
Contributor

@wackxu wackxu commented May 27, 2019 •
edited by jlewi
Loading

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.744% when pulling 2525346 on wackxu:fixpanic into 671cdab on kubeflow:master.

@johnugeorge
Copy link
Member

This was recently added by @ScorpioCPH in #1006

gaocegege
gaocegege reviewed May 28, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I think the PR can solve @ScorpioCPH 's problem.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2826c94 into kubeflow:master May 28, 2019
@wackxu wackxu deleted the fixpanic branch May 28, 2019 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@ChanYiLin ChanYiLin Awaiting requested review from ChanYiLin

@jimexist jimexist Awaiting requested review from jimexist

Assignees

@gaocegege gaocegege

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wackxu @coveralls @johnugeorge @k8s-ci-robot @gaocegege