Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presubmits failing due to lint #404

Closed
jlewi opened this issue Feb 24, 2018 · 0 comments
Closed

Presubmits failing due to lint #404

jlewi opened this issue Feb 24, 2018 · 0 comments
Assignees

Comments

@jlewi
Copy link
Contributor

jlewi commented Feb 24, 2018

Presubmits are failing due to lint issues and a bug in the code.

Here's the bug.

Your code has been rated at 9.79/10
Traceback (most recent call last):
 File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
   "__main__", fname, loader, pkg_name)
 File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
   exec code in run_globals
 File "/mnt/test-data-volume/kubeflow-tf-operator-presubmit-tfjob-e2e-402-21ef552-66-26e1/src/kubeflow/tf-operator/py/py_checks.py", line 202, in <module>
   main()
 File "/mnt/test-data-volume/kubeflow-tf-operator-presubmit-tfjob-e2e-402-21ef552-66-26e1/src/kubeflow/tf-operator/py/py_checks.py", line 198, in main
   args.func(args)
 File "/mnt/test-data-volume/kubeflow-tf-operator-presubmit-tfjob-e2e-402-21ef552-66-26e1/src/kubeflow/tf-operator/py/py_checks.py", line 54, in run_lint
   failed_files.append(full_path.strip[len(args.src_dir):])
TypeError: 'builtin_function_or_method' object has no attribute '__getitem__'

The bug is only triggered if a lint issue occurred.

The lint issues started because the docker image used by the tests got rebuilt which caused us to switch to using python3.

The lint issues are specific to python3.

@jlewi jlewi self-assigned this Feb 24, 2018
jlewi added a commit that referenced this issue Feb 24, 2018
Our worker image has been upgraded and its now using python3 to run the lint checks.
There are some lint failures that only started appearing when we went to python3
There is a bug in py_checks that only shows up if there are lint failures

Fix #404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant