Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2170: Implement validations for TrainingRuntime and ClusterTrainingRuntime #2219

Open
Tracked by #2170
tenzen-y opened this issue Aug 14, 2024 · 5 comments
Open
Tracked by #2170
Assignees

Comments

@tenzen-y
Copy link
Member

tenzen-y commented Aug 14, 2024

Related: #2170

We should create validations for the TrainingRuntime and ClusterTrainingRuntime, using the following tools:

  • Mutating Webhooks
  • CEL validations
  • controller-tools/kubebuilder annotations

/area webhook

@tenzen-y
Copy link
Member Author

/area webhook

@tenzen-y tenzen-y changed the title KEP-2170: Create controllers for TrainingRuntime and ClusterTrainingRuntime KEP-2170: Create webhooks for TrainingRuntime and ClusterTrainingRuntime Aug 15, 2024
@tenzen-y tenzen-y changed the title KEP-2170: Create webhooks for TrainingRuntime and ClusterTrainingRuntime KEP-2170: Create validation webhooks for TrainingRuntime and ClusterTrainingRuntime Aug 15, 2024
@tenzen-y tenzen-y changed the title KEP-2170: Create validation webhooks for TrainingRuntime and ClusterTrainingRuntime KEP-2170: Implement validations for TrainingRuntime and ClusterTrainingRuntime Aug 16, 2024
@andreyvelich
Copy link
Member

/assign @akshaychitneni

Copy link

@andreyvelich: GitHub didn't allow me to assign the following users: akshaychitneni.

Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @akshaychitneni

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tenzen-y
Copy link
Member Author

@akshaychitneni Could you say /assign?

@akshaychitneni
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants