Fix ineffassign error in masterRole assignment (#974)

kubeflow · Apr 23, 2019 · ef0e0a4 · ef0e0a4
1 parent 39446f2
commit ef0e0a4
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/pkg/controller.v1beta2/tensorflow/pod.go b/pkg/controller.v1beta2/tensorflow/pod.go
@@ -67,13 +67,12 @@ func (tc *TFController) reconcilePods(
 	replicas := int(*spec.Replicas)
 	restart := false
 	worker0Completed := false
-	masterRole := false
+	var masterRole bool
 
 	initializeTFReplicaStatuses(tfjob, rtype)
 
 	podSlices := tc.GetPodSlices(pods, replicas, logger)
 	for index, podSlice := range podSlices {
-		masterRole = false
 		if len(podSlice) > 1 {
 			logger.Warningf("We have too many pods for %s %d", rt, index)
 			// TODO(gaocegege): Kill some pods.